Make the libhoney client instance accessible. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulosman
force-pushed
the
paul.client_accessor
branch
from
b7e8579
to
ee5abc2
Compare
There are cases where a beeline user would like to get access to the libhoney instance directly. This makes it possible by calling `Honeycomb.libhoney` at any time.
paulosman
force-pushed
the
paul.client_accessor
branch
from
ee5abc2
to
b943ea4
Compare
martin308
approved these changes
Feb 6, 2020
| def_delegators :@client, :start_span, :add_field, :add_field_to_trace, | ||
| :current_span, :current_trace | ||
| def_delegators :@client, :libhoney, :start_span, :add_field, | ||
| :add_field_to_trace, :current_span, :current_trace |
There was a problem hiding this comment.
maybe we could add a basic test to this file for this new delegator? https://github.com/honeycombio/beeline-ruby/blob/master/spec/honeycomb/beeline_spec.rb
martin308
approved these changes
Feb 7, 2020
| expect(Honeycomb.libhoney).to eq libhoney_client | ||
| end | ||
| end | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where a beeline user would like to get access to the
libhoney instance directly. This makes it possible by calling
Honeycomb.libhoneyat any time.