-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the libhoney client instance accessible. #70
Conversation
b7e8579
to
ee5abc2
Compare
There are cases where a beeline user would like to get access to the libhoney instance directly. This makes it possible by calling `Honeycomb.libhoney` at any time.
ee5abc2
to
b943ea4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
def_delegators :@client, :start_span, :add_field, :add_field_to_trace, | ||
:current_span, :current_trace | ||
def_delegators :@client, :libhoney, :start_span, :add_field, | ||
:add_field_to_trace, :current_span, :current_trace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could add a basic test to this file for this new delegator? https://github.com/honeycombio/beeline-ruby/blob/master/spec/honeycomb/beeline_spec.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea - done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
expect(Honeycomb.libhoney).to eq libhoney_client | ||
end | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There are cases where a beeline user would like to get access to the
libhoney instance directly. This makes it possible by calling
Honeycomb.libhoney
at any time.