Fix for Issue #64 #65
Conversation
Add logic to process the PLM command "user reset to factory defaults". Also added log message if other unknown PLM commands show up.
|
This looks good to me. Such an odd error to discover, I never would have thought of this. Does this mean that 0x54 Button Event Report also needs to be added? |
|
Good question. I’ll try to get that event to fire, however I think that it only fires if the PLM is reconfigured so that it doesn’t automatically enter linking mode. In this configuration the PLM notifies the application about the button presses and the application must ask the PLM to enter linking mode. Otherwise I don’t think the PLM will fire those events. At least I’ve never seen it and I do a lot of manual linking with the i2CS devices. My guess is that so long as we don’t reconfigure the PLM for that mode we will never see the events. From: krkeegan [mailto:notifications@github.com] This looks good to me. Such an odd error to discover, I never would have thought of this. Does this mean that 0x54 Button Event Report also needs to be added? — |
|
BTW, this is a fundamental flaw in the PLM – application protocol. That protocol should have 02-command-length-payload. Then even if an unknown command springs into existence, future PLM type for instance, then MH would at least know how many bytes to throw away and could ignore the command. With this protocol if there is an unknown command we will not know how many bytes to toss. We could start tossing until we get another {02+command we recognize} but that would be only marginally better given that a command payload can contain 02 as well. I study protocols like this for a living. This is a particularly bad one but not the worse I’ve seen my own company engineer. From: Michael Stovenour [mailto:michael@stovenour.net] Good question. I’ll try to get that event to fire, however I think that it only fires if the PLM is reconfigured so that it doesn’t automatically enter linking mode. In this configuration the PLM notifies the application about the button presses and the application must ask the PLM to enter linking mode. Otherwise I don’t think the PLM will fire those events. At least I’ve never seen it and I do a lot of manual linking with the i2CS devices. My guess is that so long as we don’t reconfigure the PLM for that mode we will never see the events. From: krkeegan [mailto:notifications@github.com] This looks good to me. Such an odd error to discover, I never would have thought of this. Does this mean that 0x54 Button Event Report also needs to be added? — |
Add logic to process the PLM command "user reset to factory defaults". Also added log message if other unknown PLM commands show up.