Insteon_Thermo: Process Device Cmd Stack on Msg Ack #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed to include proper calls to _process_command_stack in the Insteon::Thermostat::_process_message routine. This likely has little effect on i2CS thermostats that had broadcast messages enabled because the thermostat immediatley issued a broadcast command which would cause MH to process the command stack. However, i1 devices or i2cs devices without broadcast enabled, may have become "locked up" within MH after the issuance of a setpoitn change.
krkeegan
added a commit
that referenced
this pull request
Mar 13, 2014
Insteon_Thermo: Process Device Cmd Stack on Msg Ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to include proper calls to _process_command_stack in the Insteon::Thermostat::_process_message routine.
This likely has little effect on i2CS thermostats that had broadcast messages enabled because the thermostat immediatley issued a broadcast command which would cause MH to process the command stack.
However, i1 devices or i2cs devices without broadcast enabled, may have become "locked up" within MH after the issuance of a setpoitn change.