Fix for Issue #26 #29
Conversation
Merge branch 'master' of https://github.com/hollie/misterhouse
Previously, insteon cleanup messages received by MH, would cause MH to clear the active message withoug confirming if the cleanup message corresponded to the active message. If multiple PLM scenes were sent sequentially, a cleanup message from one scene may have caused MH to clear out the following scenes command. This patch only clears the active message if the cleanup message matches the active message.
|
All: could somebody please provide feedback on this fix. I'd like to merge it in but I cannot decide on my own if we should merge this pull request. I have no insteon hardware to test this fix. |
|
Ok, reviewing this smaller pull request, the reasoning behind the changes sounds reasonable, but it's hard to just tell that it's ok by just eye-ing the code. krkeegan, can you confirm 3 weeks later than these changes have been good for you and you're pretty confident that they're ok to merge as is? |
|
Yes, I have been running fine without issue.
|
…df74f1fb Fix for Issue #26. Mered after krkeegan has been running this fix for 3 weeks without issues.
No description provided.