Add Support for Update_Flags and Update_OnLevel/RampRate for I2 Devices #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perties Moved to the more appropriate DimmableLight class
- Added necessary messages. - Relocated definition of extended_get_set to BaseObject as multiple objects use this - Added some better descriptions of the functions
…rt to update_flags - Update flags belongs in the Keypadlinc class as it only works on these devices - Condensed the set routine from Keypadlinc and KeypadlincRelay into Keypadlinc - Added I2 support to update_flags - - In order to support the old version of update_flags, the manner in which the routine works is a little odd as users have to pass a hexadecimal flag to the routine. This could obviously be changed or supplemented in the future.
|
One more thing, I don't own any I2 keypadlincs, so I can only guess that the changes to update_flags will work on them. They don't throw any errors on I1 devices, but they don't do anything. If someone else could test and report on this I would appreciate it. |
ghost
assigned Conflicts: lib/Insteon/BaseInsteon.pm lib/Insteon/Lighting.pm
krkeegan
added a commit
that referenced
this pull request
Aug 9, 2013
Add Support for Update_Flags and Update_OnLevel/RampRate for I2 Devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #237