Insteon: Detailed Tracking and Reporting of Statistics Related to Message #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a number of functions to track message details. Added functions to print message statistics to the log Added functions to reset the message statistics Added 2 voice commands: - print message statistics - prints details on all devices to the log - reset message statistics - resets the message statistics to 0 for all devices
Now collects and prints a total average for the entire network.
Save the object so we can use it in print_log messages
They still provide some detail on how long messages take to arrive. There may be one issue in that this may catch subsequent deliveries of the same message with a lower hops_left count. Such as when the message is delivered on the 2nd and 3rd hop. But at the same time, sometimes the messages that should take longer to arrive, as they have used more hops, somehow arrive first, so this may be a wash. In the end, the best way to avoid this problem is to use proper hop counts.
|
Here is an example of what the summary of the entire network looks like: |
Much more user friendly and descriptice name.
krkeegan
added a commit
that referenced
this pull request
Aug 9, 2013
Insteon: Detailed Tracking and Reporting of Statistics Related to Message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the most simple terms, this adds (or will add once we merge the voice commands changes) the following new voice commands:
Print Message Stats -> $device->print_message_log
Reset Message Stats -> $device->reset_message_log
Print All Message Stats -> ::Insteon::print_message_logs
Reset All Message Stats -> ::Insteon::reset_message_logs
Print Message Stats - Prints the following detail to the print log file:
NOTE: If the number of retries exceeds the value set in the configuration file for Insteon_retry_count, MisterHouse will abandon sending the message. As a result, as this number approaches Insteon_retry_count it becomes a less accurate representation of the number of retries needed to reach a device.
Print All Message Stats - Prints the same information above for all devices, plus it prints a nice summary of the average for the entire network.
Reset [All] Message Stats - Resets all of the logs and counters to 0.