Updated Insteon Motion Sensor #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/Insteon/Security.pm
Conflicts: lib/Insteon/Security.pm
Conflicts: lib/Insteon/Security.pm
Conflicts: lib/Insteon/Security.pm
-Fix last bugs and cleanup code -Remove event routines, instead if you want to tie an event to a state, you should use the child objects. Conflicts: lib/Insteon/Security.pm
…me Pass Fixes the issue found by @peloy in which multiple set messages could be called in one pass. By checking state_final, this ensures that the subsequent messages are deferred as expected. Partially fixes hollie#185
Had the order of bits reversed
The prior design failed to set the state of linked devices when motion was triggered. Routine now follows the normal design which calls set in DeviceController.
The device won't be awake for subsequent requests, and they only gum up the works.
May be of limited use, but at least in a few instances you only want to try a message once and forgo all retries.
Fix bug pointed out by Chris Dragon. Fixes #16
Newer Motion Sensors, at least since Feb 2013, respond to the get_extended_info request with D1-D2 = 0101, while older models respond with D1-D2=0001.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a number of features:
Includes merge request for Unique Message Retry Count