Using VERSION to determine the MisterHouse program version. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I propose to use the VERSION file in the root of the MisterHouse codebase to determine what version of Misterhouse we're running. This is opposed to the hardcoded version in bin/mh. I've cleaned out some legacy code that tried to determine the svn version (we're no longer using that) and now bin/mh reads the VERSION file. For the master branch this file reads 'unstable' by default. When we make a new version now, we only need to update the version number in the VERSION file to have it pushed to all locations in mh that rely on or use the version number.
|
The change to track version in a single place (and that is outside of perl code) looks good to me. I did not test this but code looks good. |
hollie
added a commit
that referenced
this pull request
Mar 18, 2013
Using VERSION to determine the MisterHouse program version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to use the VERSION file in the root of the MisterHouse codebase to determine what version of Misterhouse we're running.
This is opposed to the hardcoded version in bin/mh.
I've cleaned out some legacy code that tried to determine the svn version (we're no longer using that) and now bin/mh reads the VERSION file. For the master branch this file reads 'unstable' by default. When we make a new version now, we only need to update the version number in the VERSION file to have it pushed to all locations in mh that rely on or use the version number.