Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MulOverflow #75

Merged
merged 1 commit into from
Jun 5, 2020
Merged

MulOverflow #75

merged 1 commit into from
Jun 5, 2020

Conversation

yperbasis
Copy link
Contributor

@yperbasis yperbasis commented Jun 5, 2020 •
edited
Loading

I deliberately used full umul for clarity; this operation can be optimised later if need be.

@chfast chfast requested a review from holiman June 5, 2020 12:35
holiman
holiman approved these changes Jun 5, 2020
View reviewed changes
Copy link
Owner

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although a benchmark wouldn't hurt too.... :)
It looks like it can be shaved a bit, by not having ph there, and not doing that copy, but instead do the zero-check on the p[4,5,6,7] elements directly ?

@holiman
Copy link
Owner

holiman commented Jun 5, 2020

I'm fine with merging this though, improvements can always be done later

@holiman holiman merged commit ccc827b into holiman:master Jun 5, 2020
@yperbasis yperbasis deleted the mul_overflow branch June 5, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yperbasis @holiman @chfast