Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Junit 5 Support #340

Open
akhilasankar opened this issue Jun 29, 2021 · 4 comments
Open

Need Junit 5 Support #340

akhilasankar opened this issue Jun 29, 2021 · 4 comments

Comments

@akhilasankar
Copy link

akhilasankar commented Jun 29, 2021

I was trying to use spark-testing-base with Junit 5 but even after extending SharedJavaSparkContext I was getting jsc() as null. On a quick look I found that SharedJavaSparkContext is expecting junit 4(org.junit.Test).So in my method with junit5 @test(org.junit.jupiter.api.Test) jsc() was coming as null. If I move to junit4 everything works fine.As we are moving to junit5 I believe this is a must have change in the lib.

@jrevillard
Copy link

Hello,

I would really have support for Junit5 also....

Thanks for your work!
Best,
jerome

@devilatwork
Copy link

any updates on this?

@almogtavor
Copy link

almogtavor commented Aug 8, 2023

There's a pretty straight forward solution to this, when adding 3 classes as specified here https://medium.com/javarevisited/junit-5-spark-testing-bc8eb29b2238. I think this shall get merged to spark-testing-base. This is a very simple PR (I'm ready to do this if maintainers will show interest). @holdenk

@devilatwork
Copy link

It would be great to get it merged - I dont have Membership for medium to look at above link - would be helpful for all if it merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants