cot-874 - renaming variable name for QA comments

hmcts · Oct 16, 2024 · d6bdaef · d6bdaef
1 parent 589cd37
commit d6bdaef
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hmcts/rpx-xui-common-lib",
-  "version": "2.0.30-COT-874-v2",
+  "version": "2.0.30-COT-874-v3",
   "engines": {
     "node": ">=18.19.0"
   },

diff --git a/projects/exui-common-lib/package.json b/projects/exui-common-lib/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hmcts/rpx-xui-common-lib",
-  "version": "2.0.30-COT-874-v2",
+  "version": "2.0.30-COT-874-v3",
   "peerDependencies": {
     "launchdarkly-js-client-sdk": "^3.3.0",
     "ngx-pagination": "^3.2.1",

diff --git a/projects/exui-common-lib/src/lib/components/generic-filter/generic-filter.component.html b/projects/exui-common-lib/src/lib/components/generic-filter/generic-filter.component.html
@@ -205,7 +205,7 @@ <h3 [class]="field.titleClasses ? field.titleClasses : 'govuk-heading-s'" style=
       >{{(config.applyButtonText || 'Apply') | rpxTranslate}}</button>
       <button *ngIf="config.showCancelFilterButton"
         class="govuk-button govuk-button--secondary govuk-!-margin-bottom-0"
-        [type]="config.resubmitOnCancel ? 'submit' : 'button'"
+        [type]="config.submitOnCancel ? 'submit' : 'button'"
         id="cancelFilter"
         (click)="cancelFilter()">{{ (config.cancelButtonText || 'Cancel') | rpxTranslate}}</button>
     </div>

diff --git a/projects/exui-common-lib/src/lib/components/generic-filter/generic-filter.component.spec.ts b/projects/exui-common-lib/src/lib/components/generic-filter/generic-filter.component.spec.ts
@@ -699,7 +699,7 @@ describe('cancel button operation options', () => {
       applyButtonText: 'apply', id: 'example', persistence: 'session',
       showCancelFilterButton: true,
       cancelButtonText: 'Reset to default',
-      resubmitOnCancel: true,
+      submitOnCancel: true,
       fields: []
     };
 
@@ -715,7 +715,7 @@ describe('cancel button operation options', () => {
       applyButtonText: 'apply', id: 'example', persistence: 'session',
       showCancelFilterButton: true,
       cancelButtonText: 'Reset to default',
-      resubmitOnCancel: false,
+      submitOnCancel: false,
       fields: []
     };
     fixture.detectChanges();

diff --git a/projects/exui-common-lib/src/lib/models/filter.model.ts b/projects/exui-common-lib/src/lib/models/filter.model.ts
@@ -21,7 +21,7 @@ export interface FilterConfig {
   cancelButtonText: string;
   cancelSetting?: FilterSetting;
   showCancelFilterButton?: boolean;
-  resubmitOnCancel?: boolean;
+  submitOnCancel?: boolean;
   preSelectedNestedCheckbox?: number[];
   cancelButtonCallback?(): void;
   applyButtonCallback?(): void;