Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exio-2146-display utc time to local time #1759

Merged
merged 39 commits into from
Oct 7, 2024

Conversation

RiteshHMCTS
Copy link
Collaborator

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-2146
https://tools.hmcts.net/jira/browse/EXUI-2230

Change description

Case File View date/time as GMT rather than Local BST

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

anthonydummer
anthonydummer previously approved these changes Aug 12, 2024
Copy link

@anthonydummer anthonydummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

olusegz07
olusegz07 previously approved these changes Aug 12, 2024
Josh-HMCTS
Josh-HMCTS previously approved these changes Sep 2, 2024
Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this will do the correct local time to UTC conversion. Are there any tests for this? You need tests with times, checking that the displayed value is offset during BST

@olusegz07 olusegz07 force-pushed the exui-2146-case-file-view-time-issue branch from 8059cfe to 030ff3c Compare September 5, 2024 15:25
OgunyemiO
OgunyemiO previously approved these changes Sep 10, 2024
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine assuming that the ISO format that you are now using is that returned by CCD

Copy link

sonarcloud bot commented Oct 7, 2024

@Josh-HMCTS Josh-HMCTS merged commit 7cc8fe1 into master Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants