-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exio-2146-display utc time to local time #1759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f77e0c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this will do the correct local time to UTC conversion. Are there any tests for this? You need tests with times, checking that the displayed value is offset during BST
…com/hmcts/ccd-case-ui-toolkit into exui-2146-case-file-view-time-issue
8059cfe
to
030ff3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine assuming that the ISO format that you are now using is that returned by CCD
...ette/case-file-view/components/case-file-view-folder/case-file-view-folder.component.spec.ts
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-2146
https://tools.hmcts.net/jira/browse/EXUI-2230
Change description
Case File View date/time as GMT rather than Local BST
Does this PR introduce a breaking change? (check one with "x")