Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml config override does not change the binding variables in the config file #33

Open
eugene-yang opened this issue Jan 5, 2022 · 0 comments

Comments

@eugene-yang
Copy link
Collaborator

For config files that use config variables for run name, the overriding variables are not considered when binding the variables.
For example, when running patapsco test_config.yml --set queries.psq.path=dummy.dict and the config file is something like

run:
    name: psq-{queries.psq.path}
....
queries:
    psq:
        path: original.dict

The run name will still be psq-original.dict.

The variable checks also take place before the overriding variables are put into the config object. Ideally, it should be checked after processing the overriding variables.
https://github.com/hltcoe/patapsco/blob/master/patapsco/config.py#L118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant