Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good first issue | Feature] Implement a smarter DatetimeInspector #95

Closed
MooooCat opened this issue Dec 31, 2023 · 3 comments
Closed
Assignees
Labels
difficulty-easy enhancement New feature or request good first issue Good for newcomers

Comments

@MooooCat
Copy link
Contributor

🚅Search before asking

I have searched for issues similar to this one.

🚅Description

Update class DatetimeInspector(Inspector) in sdgx/data_models/inspectors/datetime.py to achieve:

  • Allow preset common datetime format string, such as: "%Y/%m/%d", "%Y-%m-%d", etc.;
  • Allow users to specify uncommon but clear datetime format string: "%b-%d-%Y", etc.;

Same as the existing DatetimeInspector, after running the fit method, you can infer which columns belong to the Datetime type. After implementing this Issue, DatetimeInspector can output the specific format strings of some of the columns (not all of them), will help improve the quality of synthetic data.

🏕Solution(optional)

Briefly speaking, the following steps are required:

  • Modify member variables, add preset Datetime format string;
  • Modify the __init__ method, add parameters in user-specified format;
  • Modify the fit method, add the Datetime format string matching steps;
  • Modify the inspect method and add the output Datetime format string, which will be passed to metadata;
  • During the implementation process, performance also needs to noticed.
@MooooCat MooooCat added enhancement New feature or request good first issue Good for newcomers difficulty-easy labels Dec 31, 2023
@Femi-lawal
Copy link
Contributor

Hi @MooooCat please can I work on this?

@MooooCat
Copy link
Contributor Author

Hi Lawal,

Sure, feel free to open a PR any time.

@Femi-lawal

@Wh1isper
Copy link
Collaborator

Implemented in #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty-easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants