-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: same-block inscription location pointer comparison #248
Conversation
Vercel deployment URL: https://ordinals-cihmva8dq-blockstack.vercel.app 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 58 58
Lines 6100 6102 +2
Branches 535 535
=======================================
+ Hits 5808 5810 +2
Misses 289 289
Partials 3 3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## [1.2.4](v1.2.3...v1.2.4) (2023-10-06) ### Bug Fixes * same-block inscription location pointer comparison ([#248](#248)) ([6fabb40](6fabb40))
🎉 This PR is included in version 1.2.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.2.4](hirosystems/ordinals-api@v1.2.3...v1.2.4) (2023-10-06) ### Bug Fixes * same-block inscription location pointer comparison ([#248](hirosystems/ordinals-api#248)) ([6fabb40](hirosystems/ordinals-api@6fabb40))
The postgres.js config casts the postgres
numeric
type as a string when returning it to JS, causing number comparisons to break when trying to determine a inscription's genesis when it is created and transferred in the same block.This PR simply parses values as
number
before comparing block height and transaction index.