fix: same-block inscription location pointer comparison #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://ordinals-cihmva8dq-blockstack.vercel.app 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 58 58
Lines 6100 6102 +2
Branches 535 535
=======================================
+ Hits 5808 5810 +2
Misses 289 289
Partials 3 3
|
blockstack-devops
pushed a commit
that referenced
this pull request
Oct 6, 2023
## [1.2.4](v1.2.3...v1.2.4) (2023-10-06) ### Bug Fixes * same-block inscription location pointer comparison ([#248](#248)) ([6fabb40](6fabb40))
|
🎉 This PR is included in version 1.2.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Oct 9, 2023
g0drlc
added a commit
to g0drlc/btc-ordinals-api
that referenced
this pull request
Jul 14, 2024
## [1.2.4](hirosystems/ordinals-api@v1.2.3...v1.2.4) (2023-10-06) ### Bug Fixes * same-block inscription location pointer comparison ([#248](hirosystems/ordinals-api#248)) ([6fabb40](hirosystems/ordinals-api@6fabb40))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The postgres.js config casts the postgres
numerictype as a string when returning it to JS, causing number comparisons to break when trying to determine a inscription's genesis when it is created and transferred in the same block.This PR simply parses values as
numberbefore comparing block height and transaction index.