Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation additions and fixes #804

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Conversation

Jonxslays
Copy link
Contributor

Summary

This PR adds various fixes and clarifications to the documentation.

  • Adds the add_component method to api.special_endpoints.ActionRowBuilder
  • Adds nox and towncrier requirements to CONTRIBUTING.md
  • Adds docstrings to the remaining undocumented GatewayBot methods

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

N/A

Clarify nox and towncrier reqs for contributors
davfsa
davfsa previously requested changes Sep 30, 2021
CONTRIBUTING.md Outdated Show resolved Hide resolved
changes/804.doc.md Outdated Show resolved Hide resolved
changes/804.doc.md Show resolved Hide resolved
changes/804.doc.md Outdated Show resolved Hide resolved
changes/804.feature.md Outdated Show resolved Hide resolved
@davfsa davfsa added the documentation Improvements or additions to documentation label Sep 30, 2021
@davfsa
Copy link
Member

davfsa commented Sep 30, 2021

LGTM, would like to get a second view of Snab too 👍

@davfsa davfsa merged commit e9c52ac into hikari-py:master Oct 3, 2021
@Jonxslays Jonxslays deleted the task/docs branch November 29, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants