Add proper ChannelOverwriteEntryInfo deserialization for field "type" #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PermissionOverwriteType object.
|
i looked through git blame and this was originally fixed by adding the Union[...,str] which was added here but i dont really see a reason to follow the inconsistent behaviour of discord, converting the str to an int and with that into a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
field "type" of ChannelOverwriteEntryInfo does not get deserialized properly. I've added a conversion from a str to an int to deserialize into the PermissionOverwriteType Enum.
This is because of discord beeing inconsistent. Normaly the
PermissionOverwriteTypeis represented as an int. Docs but when sent as Optional Audit Entry Info, it is an string. DocsChecklist
noxand all the pipelines have passed.Related issues
Fix #1992