Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten the component builders #1533

Merged

Conversation

FasterSpeeding
Copy link
Collaborator

Summary

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

@davfsa davfsa added the enhancement New feature or request label Mar 14, 2023
@FasterSpeeding FasterSpeeding marked this pull request as ready for review March 25, 2023 16:35
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the changes proposed in the pr

hikari/impl/special_endpoints.py Show resolved Hide resolved
hikari/api/special_endpoints.py Outdated Show resolved Hide resolved
hikari/api/special_endpoints.py Outdated Show resolved Hide resolved
hikari/impl/special_endpoints.py Show resolved Hide resolved
hikari/impl/special_endpoints.py Show resolved Hide resolved
hikari/impl/special_endpoints.py Show resolved Hide resolved
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to test it in the wild!

@FasterSpeeding FasterSpeeding merged commit 6e8cf9b into hikari-py:master Mar 29, 2023
@FasterSpeeding FasterSpeeding deleted the task/components-refactor branch March 29, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants