Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CacheView.iterator in favour of using itertools #1289

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Sep 21, 2022

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

@FasterSpeeding
Copy link
Collaborator

I mean this is still helpful by itself: its more ergonomic if you want to do an async operation over the entries in a cache using an async iterator and collect/iterate over the results rather than directly building an impl of them but it isn't necessary and is arguably misleading so I don't mind getting rid of it.

@davfsa
Copy link
Member Author

davfsa commented Sep 23, 2022

That is the idea behind it. In async cache views, the iterator can still be added if needed :)

@FasterSpeeding
Copy link
Collaborator

That is the idea behind it. In async cache views, the iterator can still be added if needed :)

Fine by me then

@davfsa davfsa merged commit 68ee392 into hikari-py:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants