Fix voice silently failing to connect to channel #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davfsa
reviewed
Aug 9, 2022
Co-authored-by: davfsa <davfsa@gmail.com>
…ie/hikari into bug/voice-fail-connect
davfsa
reviewed
Aug 9, 2022
davfsa
approved these changes
Aug 9, 2022
FasterSpeeding
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hikari.impl.VoiceImpl.connect_towould silently fail (awaits function forever) to connect to a voice channel if the guild_id or channel_id was wrong. This PR adds timeout when connecting.hikari.errors.VoiceErroris raised when this timeout is reached. Atimeoutkwarg is added if users want to change the timeout. The default timeout is 5s.I could not find how they handle errors in this section of the API docs but it looks like they just dont respond with anything so I decided a timeout would be the best implementation.
Checklist
noxand all the pipelines have passed.