Remove store sku related application fields and store channels #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are these removed completely from the API? As far as I am aware there are still some lindering around (cant check atm, but check one of a store channel I have access to later today) |
|
Looks like they are all gone. All good then :) |
davfsa
previously approved these changes
Mar 25, 2022
FasterSpeeding
force-pushed
the
task/remove-store-channel
branch
from
b381584
to
84ac5b1
Compare
davfsa
approved these changes
Mar 25, 2022
The assumption here is that all of the store (channel) specific application fields should be treated as likely to be removed in the future since they serve no purpose without the store and primary_sku_id + slug were never useful to bots as far as the documented API goes to begin with anyways. |
hypergonial
pushed a commit
to hypergonial/hikari
that referenced
this pull request
Mar 19, 2024
* Remove mention of deprecated GuildStoreChannel Deprecated and removed in hikari-py#1092 * Minor spellchecking * MANAGE_INVITES is now CREATE_INSTANT_INVITES https://discord.com/developers/docs/resources/guild#add-guild-member * Migrate to MANAGE_GUILD_EXPRESSIONS * Expand GUILDER_MEMBERS intent * Expand `undefined` * Housekeeping: New line to appease formatter * Expand and beautify `hikari.undefined`'s docs * stdlib reference linking * Change "Bot" tab reference to Discord's Dev Portal This should be a good kickstarter. Should. * Add missing `position` arg in `add_role()` * Make `Intents`'s docs a bit more helpful * Address MkDocs' build warning * Housekeeping: Appease `flake8` * Migrate leftover backtick reference * Change MANAGE_PERMISSIONS to MANAGE_ROLES This could be verified by letting the bot have Manage Permissions permission in a channel and check that channel's overwrites. * Expand Webhook.token according to scope * More stdlib migration * Expand aliases * Migrate leftover MANAGE_INVITES * Expand Flag's reference * Typo fix * Expand BasicAuthHeader * Resolve READ_MESSAGE to VIEW_CHANNEL * Expand internal Enum * Expand MEMBERS to CacheComponent.MEMBERS * Bump MkDocs dependencies * Make cross-references inline code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
noxand all the pipelines have passed.Related issues