Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the component deserialize methods on the entity factory #1074

Merged
merged 2 commits into from
Mar 13, 2022
Merged

Hide the component deserialize methods on the entity factory #1074

merged 2 commits into from
Mar 13, 2022

Conversation

FasterSpeeding
Copy link
Collaborator

Summary

These shouldn't have ever been exposed as they're only ever used within the entity factory

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

@FasterSpeeding FasterSpeeding changed the title Hide the component deserialize methods on the entity factory Hide the component variant deserialize methods on the entity factory Mar 12, 2022
@FasterSpeeding FasterSpeeding changed the title Hide the component variant deserialize methods on the entity factory Hide the component deserialize methods on the entity factory Mar 12, 2022
@FasterSpeeding FasterSpeeding merged commit c4ed995 into hikari-py:master Mar 13, 2022
@FasterSpeeding FasterSpeeding deleted the task/hide-component-deserialize-methods branch March 13, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davfsa davfsa davfsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FasterSpeeding @davfsa