Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cpp) Regression between 9.10.0 and 9.11.0, "class kernel" is not highlighted inside lambda #3103

Closed
andykras opened this issue Apr 4, 2021 · 3 comments
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language

Comments

@andykras
Copy link

andykras commented Apr 4, 2021

Describe the issue
"class kernel" is not highlighted inside lambda

Which language seems to have the issue?
cpp

Are you using highlight or highlightAuto?
Both highlight and highlightBlock gives the same result.
Also tested against 10.7.1 with highlightElement

...

Sample Code to Reproduce
http://jsfiddle.net/andykras/wpdcv9q0/15 Highlight.js 9.11.0 NOT worked

http://jsfiddle.net/andykras/9mvuaybz/22 Highlight.js 9.10.0 worked

class kernel_br{};

q.submit([&](handler &cgh)
{
  // here <class kernel_br> should be highlighted
  cgh.parallel_for<class kernel_br>(workRange, reduction(sumAcc, 0));
});

cgh.parallel_for<class kernel_br>(workRange, reduction(sumAcc, 0));

Expected behavior
"class kernel" should be highlighted the same way it's in lambda or not.

Additional context
This is a C++ SYCL kernels, check more code like this here https://developer.codeplay.com/products/computecpp/ce/guides/sycl-guide/multiple-kernels#multiple-kernels

@andykras andykras added bug help welcome Could use help from community language labels Apr 4, 2021
@joshgoebel
Copy link
Member

I'll look into this after #3078 is merged.

@joshgoebel joshgoebel added the good first issue Should be easier for first time contributors label Apr 9, 2021
@joshgoebel
Copy link
Member

Seems resolved in main already, likely by #3078.

@andykras
Copy link
Author

Seems resolved in main already, likely by #3078.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language
Projects
None yet
Development

No branches or pull requests

2 participants