Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce knock user jwt and log when missing. #9615

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −0
Open

enforce knock user jwt and log when missing. #9615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14b0bc9
Do not attempt to authenticate or identify if a user knockJWT is not …
burtonator Oct 21, 2024
6c224b3
...
burtonator Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...es/commonwealth/client/scripts/views/components/KnockNotifications/KnockNotifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ export const KnockNotifications = () => {
return;
}

if (!user.knockJWT) {
console.warn('user knockJWT not set! Will not attempt to identify.');
return;
}

const timezone = getBrowserTimezone();
async function doAsync() {
knock.authenticate(`${user.id}`, user.knockJWT);
Expand Down
Loading