Israel.9546.incorrect 404 redirect #9608
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9546
Description of Changes
/dashboard/for-you
NOTE: I chose this method of redirection based off of the multiple ways we are using/showing the 404 page. @masvelio In regards to this comment you made on my previous PR, I chose to do it this way instead of possibly doing an automatic redirect if the url is incorrect, because I worried that if I did that it would cause a lot of downstream bugs because we show this page in many different places and use it in different ways.
"How We Fixed It"
-made a check to see if user was logged in and changed messages based on that, and added Sign in and Home buttons to correspond with the different messages.
Test Plan
/dashboard/for-you