Refactor getTopics #9584

Rotorsoft · 2024-10-17T21:18:15Z

Link to Issue

Closes: #9103

Description of Changes

Replaces Topic client state with TopicView schema, returned by query
Refactors get_topics with new query

"How We Fixed It"

Test Plan

Make sure you can view, create, update topics
@rbennettcw how can we test contest related stuff here?

Deployment Plan

Other Considerations

libs/model/src/community/GetTopics.query.ts

rbennettcw · 2024-10-18T17:45:08Z

When I create a contest and go to the Create Thread page, there's an output validation error and the topics dropdown doesn't show

rbennettcw · 2024-10-18T17:52:52Z

INTERNAL_SERVER_ERROR: [ZodError] thread.getTopics: [
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "undefined",
    "path": [
      2,
      "active_contest_managers",
      0,
      "contest_address"
    ],
    "message": "Required"
  },
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "undefined",
    "path": [
      2,
      "active_contest_managers",
      0,
      "community_id"
    ],
    "message": "Required"
  },
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "undefined",
    "path": [
      2,
      "active_contest_managers",
      0,
      "name"
    ],
    "message": "Required"
  },
  {
    "code": "invalid_type",
    "expected": "array",
    "received": "undefined",
    "path": [
      2,
      "active_contest_managers",
      0,
      "payout_structure"
    ],
    "message": "Required"
  },
  {
    "code": "invalid_type",
    "expected": "number",
    "received": "undefined",
    "path": [
      2,
      "active_contest_managers",
      0,
      "interval"
    ],
    "message": "Required"
  },
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "undefined",
    "path": [
      2,
      "active_contest_managers",
      0,
      "created_at"
    ],
    "message": "Required"
  },
  {
    "code": "invalid_type",
    "expected": "array",
    "received": "null",
    "path": [
      2,
      "active_contest_managers",
      0,
      "content"
    ],
    "message": "Expected array, received null"
  }
]

packages/commonwealth/client/scripts/state/api/topics/fetchTopics.ts

mzparacha · 2024-10-21T13:21:46Z

Create thread is failing with this error

ERROR (utils.ts): INTERNAL_SERVER_ERROR: [ZodError] thread.createThread: [
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "number",
    "path": [
      "reaction_weights_sum"
    ],
    "message": "Expected string, received number"
  }
] {"fingerprint":"INTERNAL_SERVER_ERROR-ZodError-thread.createThread-invalid_type"}
    err: {
      "type": "ZodError",
      "message": "[\n  {\n    \"code\": \"invalid_type\",\n    \"expected\": \"string\",\n    \"received\": \"number\",\n    \"path\": [\n      \"reaction_weights_sum\"\n    ],\n    \"message\": \"Expected string, received number\"\n  }\n]",
      "stack":
          ZodError: [
            {
              "code": "invalid_type",
              "expected": "string",
              "received": "number",
              "path": [
                "reaction_weights_sum"
              ],
              "message": "Expected string, received number"
            }
          ]
              at get error [as error] (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/zod@3.23.6/node_modules/zod/lib/index.mjs:587:31)
              at ZodObject.parseAsync (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/zod@3.23.6/node_modules/zod/lib/index.mjs:715:22)
              at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
              at async outputMiddleware (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:308:26)
              at async callRecursive (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:451:32)
              at async callRecursive (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:451:32)
              at <anonymous> (/Users/ninja/workspace/commonwealth/libs/adapters/src/trpc/middleware.ts:180:22)
              at async callRecursive (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:451:32)
              at async callRecursive (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:451:32)
              at async resolve (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:481:24)
      "aggregateErrors": [
        {
          "type": "Object",
          "message": "Expected string, received number",
          "stack":
              
          "code": "invalid_type",
          "expected": "string",
          "received": "number",
          "path": [
            "reaction_weights_sum"
          ]
        }
      ],
      "issues": [
        {
          "code": "invalid_type",
          "expected": "string",
          "received": "number",
          "path": [
            "reaction_weights_sum"
          ],
          "message": "Expected string, received number"
        }
      ],
      "name": "ZodError"
    }

packages/commonwealth/client/scripts/models/Thread.ts

Rotorsoft · 2024-10-21T13:51:31Z

Create thread is failing with this error

ERROR (utils.ts): INTERNAL_SERVER_ERROR: [ZodError] thread.createThread: [
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "number",
    "path": [
      "reaction_weights_sum"
    ],
    "message": "Expected string, received number"
  }
] {"fingerprint":"INTERNAL_SERVER_ERROR-ZodError-thread.createThread-invalid_type"}
    err: {
      "type": "ZodError",
      "message": "[\n  {\n    \"code\": \"invalid_type\",\n    \"expected\": \"string\",\n    \"received\": \"number\",\n    \"path\": [\n      \"reaction_weights_sum\"\n    ],\n    \"message\": \"Expected string, received number\"\n  }\n]",
      "stack":
          ZodError: [
            {
              "code": "invalid_type",
              "expected": "string",
              "received": "number",
              "path": [
                "reaction_weights_sum"
              ],
              "message": "Expected string, received number"
            }
          ]
              at get error [as error] (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/zod@3.23.6/node_modules/zod/lib/index.mjs:587:31)
              at ZodObject.parseAsync (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/zod@3.23.6/node_modules/zod/lib/index.mjs:715:22)
              at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
              at async outputMiddleware (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:308:26)
              at async callRecursive (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:451:32)
              at async callRecursive (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:451:32)
              at <anonymous> (/Users/ninja/workspace/commonwealth/libs/adapters/src/trpc/middleware.ts:180:22)
              at async callRecursive (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:451:32)
              at async callRecursive (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:451:32)
              at async resolve (file:///Users/ninja/workspace/commonwealth/node_modules/.pnpm/@trpc+server@10.45.2/node_modules/@trpc/server/dist/index.mjs:481:24)
      "aggregateErrors": [
        {
          "type": "Object",
          "message": "Expected string, received number",
          "stack":
              
          "code": "invalid_type",
          "expected": "string",
          "received": "number",
          "path": [
            "reaction_weights_sum"
          ]
        }
      ],
      "issues": [
        {
          "code": "invalid_type",
          "expected": "string",
          "received": "number",
          "path": [
            "reaction_weights_sum"
          ],
          "message": "Expected string, received number"
        }
      ],
      "name": "ZodError"
    }

@mzparacha can you provide some reproduction steps? Seems to be working fine on my end.

mzparacha · 2024-10-21T14:05:47Z

@mzparacha can you provide some reproduction steps? Seems to be working fine on my end.

Apologies, I was missing a migration run from master branch.

mzparacha

lgtm!

rotorsoft added 6 commits October 17, 2024 17:17

fist pass

6993d39

fix topics

2b36e96

move query to community

763d23f

remove client Topic state type and use TopicView from schemas

b6d0894

fix lint

63af2b6

remove test

933ed5f

Rotorsoft requested review from mzparacha, timolegros and rbennettcw October 18, 2024 16:14

Merge branch 'master' into rotorsoft/9103-get-topics-query

5824562

rbennettcw reviewed Oct 18, 2024

View reviewed changes

libs/model/src/community/GetTopics.query.ts Outdated Show resolved Hide resolved

fix query

5b3bb0d

Rotorsoft requested a review from rbennettcw October 18, 2024 16:42

fix query

e77d5b7

rbennettcw approved these changes Oct 18, 2024

View reviewed changes

add coalesce to cancelled

79a75cf

mzparacha reviewed Oct 21, 2024

View reviewed changes

packages/commonwealth/client/scripts/state/api/topics/fetchTopics.ts Show resolved Hide resolved

Merge branch 'master' into rotorsoft/9103-get-topics-query

282d9fb

mzparacha reviewed Oct 21, 2024

View reviewed changes

packages/commonwealth/client/scripts/models/Thread.ts Show resolved Hide resolved

fix invalidate, move getTopics to community router

79a5417

mzparacha approved these changes Oct 21, 2024

View reviewed changes

Rotorsoft merged commit d5240f1 into master Oct 21, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor getTopics #9584

Refactor getTopics #9584

Rotorsoft commented Oct 17, 2024 •

edited

Loading

rbennettcw commented Oct 18, 2024

rbennettcw commented Oct 18, 2024

mzparacha commented Oct 21, 2024

Rotorsoft commented Oct 21, 2024

mzparacha commented Oct 21, 2024

mzparacha left a comment

Refactor getTopics #9584

Refactor getTopics #9584

Conversation

Rotorsoft commented Oct 17, 2024 • edited Loading

Link to Issue

Description of Changes

"How We Fixed It"

Test Plan

Deployment Plan

Other Considerations

rbennettcw commented Oct 18, 2024

rbennettcw commented Oct 18, 2024

mzparacha commented Oct 21, 2024

Rotorsoft commented Oct 21, 2024

mzparacha commented Oct 21, 2024

mzparacha left a comment

Choose a reason for hiding this comment

Rotorsoft commented Oct 17, 2024 •

edited

Loading