added Cancel button functionality to child comment #9569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzparacha
approved these changes
Oct 16, 2024
packages/commonwealth/client/scripts/views/components/Comments/CreateComment.tsx
Outdated
Show resolved
Hide resolved
masvelio
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9562
Description of Changes
"How We Fixed It"
added
|| isReplyinglogic to the Cancel button to show Cancel when replying.Test Plan
-go to a thread with at least 1 comment
-confirm that the editor at the top of the thread does not show a Cancel button without first entering text
-click Reply
-confirm that you now see the Cancel button below the editor and that you can close it without having to enter any text first
Screen.Recording.2024-10-16.at.3.26.04.PM.mov