Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade canvas to 0.11.0 #9494

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

rjwebb
Copy link
Collaborator

@rjwebb rjwebb commented Oct 9, 2024

This PR upgrades the Canvas version to 0.11.0.

Changes:

  • libp2p changed their API for creating private keys and peer ids (PR). Canvas adopted the new API in version 0.11.0, so we need to update our code as well. The underlying format of the PEER_ID env var has not changed.
  • The way we initialise the Canvas object has changed, we now pass libp2p-specific config fields to app.startLibp2p
  • The constructor for SIWESigner has changed slightly, if we create a SIWESigner without a signer config value then it generates an ethers wallet and then saves it in local storage. This does not affect how Commonwealth works because we always pass in a signer config value (which would be some kind of handle to the MetaMask/WalletConnect/etc browser extension) but it meant that some of the test fixture code had to be changed to explicitly always create a new ethers wallet.

Link to Issue

Closes: #TODO

Description of Changes

  • Adds FIXME widget to TODO page.

"How We Fixed It"

Test Plan

  • Unit tested the FIXME() call.
  • CA (click around) tested on local and frack:
    • TODO page

Deployment Plan

Other Considerations

@rjwebb rjwebb marked this pull request as ready for review October 14, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant