-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Return parsed ingredients (name, unit, quantity) #733
base: main
Are you sure you want to change the base?
Conversation
update tests
@hhursev would you be interested in this type of improvement for project? |
Hey! Interested in what quantulum3 -like package can do out of the box on top of our I feel like if you are happy with the results you should continue on this idea! I'm thinking the proper approach for us is:
so in a sense what you are proposing won't be in the core package but may overwrite the default |
Personally I'd love something like this! |
@hhursev @lizozom An example from the README:
Note: I am the author of this package and I'm shilling it because it works better than any other open source solution I could find (there are other good ingredient parsers out there, but most of them require large additional dependencies) and it filled a big hole in my work. |
Currently ingredients are returned as unprocessed strings.
I'm proposing a change to the existing
ingredients
API to returned an array of objects with the following structure (usingquantulum3
):We could also make this a non breaking change by adding an optional input parameter or separating this into two APIs.
This PR only updates a few tests to demonstrate the change, and if the community agrees, I can update all other tests\parsers and the documentation.
Curious to hear what you think!