Implement registry-based string preprocessing as list of callables #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgrecco
reviewed
Dec 4, 2019
jthielen
force-pushed
the
string-preprocessor
branch
from
2e48566
to
ec76aa1
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 5, 2019
911: Implement registry-based string preprocessing as list of callables r=hgrecco a=jthielen As suggested in #429, this implements simple registry-based unit/expression string preprocessing through a list of callables. There are a couple questions I was wondering about: - Is the added argument to the docstring sufficient documentation, or would additional documentation (such as an example with percent as in #429) be useful? - Right now, the unit string preprocessing occurs in `parse_units`, rather than `_parse_units`, which avoids the cache. For performance reasons, would it be worth the extra complexity of cache invalidation to have this moved inside `_parse_units` after the cache check? Closes #429 Closes #851 Co-authored-by: Jon Thielen <github@jont.cc>
|
i am merging this now, but I think before launching the next version we need to revisit the docs and improve it. |
Build succeeded |
2 tasks
tgbugs
added a commit
to tgbugs/parsercomb
that referenced
this pull request
Jun 22, 2022
there was a bugfix in pint 19 that means that the percent sign in units has to be expanded so that it is not treated as a unary operator see hgrecco/pint#911 for details/examples/links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #429, this implements simple registry-based unit/expression string preprocessing through a list of callables.
There are a couple questions I was wondering about:
parse_units, rather than_parse_units, which avoids the cache. For performance reasons, would it be worth the extra complexity of cache invalidation to have this moved inside_parse_unitsafter the cache check?Closes #429
Closes #851