-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving TinyGo support #269
Comments
@dlmrich that’s great to hear! I’ll check it out and update the instructions for using that soon |
Hey @slimsag , hope you're well. I'm curious if there has been any updates here or if there's anything that TinyGo is pending on to make improvements in Vecty? Thanks! |
Things here have improved quite considerably on the TinyGo side:
I haven't yet had a chance to try out this, but if someone wants to:
I suspect many things will 'just work' now. |
Has anyone had a chance to try this recently? I would agree with the above statement! 😸 |
I just tried running vecty's tests with tinygo dev (well, with my setenv branch) after making the two changes above.
The next step, if someone has the time, might be to create minimal test cases for one or more of those & file them individually in https://github.com/tinygo-org/tinygo/issues. |
TestCore (at least) seems to be testing that things panic in the appropriate places, which means we should retest with a tinygo branch with tinygo-org/tinygo#2331 applied to it (since otherwise all panics are fatal.) |
Seemed to die pretty quickly on branch recover3:
Also, there was this warning first; my tinygo was built using "make", fwiw.
|
It may be the case that TinyGo just doesn't support |
The recover support is still draft, fwiw. |
Unfortunately, #2331 is only for non-WebAssembly instruction sets. WebAssembly is kind of a pain to support... |
@aykevl makes sense, thanks for that info! We don't use I think the next step here is for someone to try running the examples with tinygo and/or sending a PR to disable those tests when compiling with TinyGo. |
I've just tried to run the hellovecty example. Should I have followed these instructions?
Here the browser console output:
|
After removing 1 and 2 The browser displayed "Hello Vecty!" The browser console output still has some errors:
|
I've tried running the "Markdown" example Here's the browser console output
|
Experimental TinyGo support in Vecty has landed: tinygo-org/tinygo#1282 (comment)
For details on what that means, its limitations, and how to use it - see: #243 (comment)
This issue is for tracking improvements to TinyGo support that would get it out of experimental status.
example/markdown
's dependencies.example/todomvc
's dependencies.reflect.New
support, meaningvecty.Copier
must be implemented for all components. Trying to implementreflect.New()
tinygo-org/tinygo#1087%T
show justT
instead ofmy/package.MyComponent
wasmserve
equivilent for TinyGo yetThe text was updated successfully, but these errors were encountered: