Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You're using a version of Nixpkgs that doesn't support the includeStorePaths parameter in d #217

Open
lunik1 opened this issue Sep 26, 2023 · 1 comment

Comments

@lunik1
Copy link
Contributor

lunik1 commented Sep 26, 2023

I am getting the following error after updating my arion compose to use the latest NixOS unstable:

trace: warning: You're using a version of Nixpkgs that doesn't support the includeStorePaths
parameter in dockerTools.streamLayeredImage. Without this, Arion's
useHostStore does not achieve the intended speedup.

Not sure if related, but I get a lot of cache misses when rebuilding too.

@deliciouslytyped
Copy link

deliciouslytyped commented Oct 11, 2023

Automatic bisect with

[nix-shell:~/nixpkgs]$ git bisect reset && git bisect start HEAD $(git rev-list -n 1 --before="3 months ago" master)
Updating files: 100% (11133/11133), done.
Previous HEAD position was fa81ad84ed29 Merge pull request #244101 from r-ryantm/auto-update/komga
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
Bisecting: 16174 revisions left to test after this (roughly 14 steps)
[a99da55dfbee0df689503571b8084d66070d1569] Merge staging-next into staging

[nix-shell:~/nixpkgs]$ cat ../bisect/bisectscript
#!/usr/bin/env bash
set -x
arion cat -f /home/user/bisect/arion-compose.nix -p /home/user/bisect/arion-pkgs.nix |& tee /dev/tty | { timeout 20 awk "/t support the includeStorePaths/ { found=1; exit(1); } END { if (!found) exit(124); }"; [[ $? -eq 124 ]]; }
exit $?
...
[nix-shell:~/nixpkgs]$ git bisect run ../bisect/bisectscript
...
38c1400f67f6af73821d5be82f0ddab548e707e2 is the first bad commit
commit 38c1400f67f6af73821d5be82f0ddab548e707e2
Author: Robert Scott <code@humanleg.org.uk>
Date:   Sun Jan 1 23:43:00 2023 +0000

    dockerTools: use makeOverridable for buildImage family of functions

    this allows nix users to modify existing images without having
    to rely on container image inheritance mechanisms via fromImage

 pkgs/build-support/docker/default.nix | 15 +++++++++------                                                                                                                                                      1 file changed, 9 insertions(+), 6 deletions(-)
bisect found first bad commit      

attributes the problem to NixOS/nixpkgs#208944 which wraps dockerTools functions in makeOverridable, presumably breaking functionArgs.

I have no idea if this is actually breaking some sort of caching or not.

The warning comes from

includeStorePathsWarningAndDefault = lib.warn ''

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants