-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add support for bulk deletion to ark schedule delete
refactor and move DeleteOptions struct and methods unexport fields not used outside the package in DeleteOptions struct refactor BindFlags() to work with name of command fix constructor Signed-off-by: Shubheksha Jalan <jshubheksha@gmail.com>
- Loading branch information
1 parent
889b220
commit 66bcbc0
Showing
5 changed files
with
220 additions
and
192 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
/* | ||
Copyright 2018 the Heptio Ark contributors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package cli | ||
|
||
import ( | ||
"bufio" | ||
"errors" | ||
"fmt" | ||
"os" | ||
"strings" | ||
|
||
"github.com/heptio/ark/pkg/client" | ||
"github.com/heptio/ark/pkg/cmd/util/flag" | ||
clientset "github.com/heptio/ark/pkg/generated/clientset/versioned" | ||
|
||
"github.com/spf13/cobra" | ||
"github.com/spf13/pflag" | ||
) | ||
|
||
// DeleteOptions contains parameters used for deleting a restore. | ||
type DeleteOptions struct { | ||
Names []string | ||
all bool | ||
Selector flag.LabelSelector | ||
Confirm bool | ||
Client clientset.Interface | ||
Namespace string | ||
singularTypeName string | ||
} | ||
|
||
func NewDeleteOptions(singularTypeName string) *DeleteOptions { | ||
o := &DeleteOptions{} | ||
o.singularTypeName = singularTypeName | ||
return o | ||
} | ||
|
||
// Complete fills in the correct values for all the options. | ||
func (o *DeleteOptions) Complete(f client.Factory, args []string) error { | ||
o.Namespace = f.Namespace() | ||
client, err := f.Client() | ||
if err != nil { | ||
return err | ||
} | ||
o.Client = client | ||
o.Names = args | ||
return nil | ||
} | ||
|
||
// Validate validates the fields of the DeleteOptions struct. | ||
func (o *DeleteOptions) Validate(c *cobra.Command, f client.Factory, args []string) error { | ||
if o.Client == nil { | ||
return errors.New("Ark client is not set; unable to proceed") | ||
} | ||
var ( | ||
hasNames = len(o.Names) > 0 | ||
hasAll = o.all | ||
hasSelector = o.Selector.LabelSelector != nil | ||
) | ||
if !xor(hasNames, hasAll, hasSelector) { | ||
return errors.New("you must specify exactly one of: specific restore name(s), the --all flag, or the --selector flag") | ||
} | ||
|
||
return nil | ||
} | ||
|
||
// BindFlags binds options for this command to flags. | ||
func (o *DeleteOptions) BindFlags(flags *pflag.FlagSet) { | ||
flags.BoolVar(&o.Confirm, "confirm", o.Confirm, "Confirm deletion") | ||
flags.BoolVar(&o.all, "all", o.all, "Delete all "+o.singularTypeName+"s") | ||
flags.VarP(&o.Selector, "selector", "l", "Delete all "+o.singularTypeName+"s matching this label selector") | ||
} | ||
|
||
// GetConfirmation ensures that the user confirms the action before proceeding. | ||
func GetConfirmation() bool { | ||
reader := bufio.NewReader(os.Stdin) | ||
|
||
for { | ||
fmt.Printf("Are you sure you want to continue (Y/N)? ") | ||
|
||
confirmation, err := reader.ReadString('\n') | ||
if err != nil { | ||
fmt.Fprintf(os.Stderr, "error reading user input: %v\n", err) | ||
return false | ||
} | ||
confirmation = strings.TrimSpace(confirmation) | ||
if len(confirmation) != 1 { | ||
continue | ||
} | ||
|
||
switch strings.ToLower(confirmation) { | ||
case "y": | ||
return true | ||
case "n": | ||
return false | ||
} | ||
} | ||
} | ||
|
||
// Xor returns true if exactly one of the provided values is true, | ||
// or false otherwise. | ||
func xor(val bool, vals ...bool) bool { | ||
res := val | ||
|
||
for _, v := range vals { | ||
if res && v { | ||
return false | ||
} | ||
res = res || v | ||
} | ||
return res | ||
} |
Oops, something went wrong.