Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: overhaul undici interface #19

Open
Nytelife26 opened this issue Apr 9, 2021 · 4 comments · May be fixed by #33
Open

refactor: overhaul undici interface #19

Nytelife26 opened this issue Apr 9, 2021 · 4 comments · May be fixed by #33
Assignees
@Nytelife26 @tbnritzdoge
Labels
enhancement New feature or request

Comments

@Nytelife26
Copy link
Collaborator

Nytelife26 commented Apr 9, 2021 •
edited
Loading

This would solve...

The implementation should look like...

  • Allow duplex / writeable streams
  • Enable the usage of a pool, agent, or anything that implements a dispatcher as opposed to exclusively an undici client
  • Add redirect infrastructure

Typing will not be difficult as Agent, Pool and Client all implement Dispatcher.

I have also considered...

N/A.

Additional context

N/A.
@Nytelife26 Nytelife26 added the enhancement New feature or request label Apr 9, 2021
@Nytelife26 Nytelife26 self-assigned this Apr 9, 2021
@wonderlandpark
Copy link

I think we need a signal too. (for request aborting)

@tbnritzdoge
Copy link
Member

I think we need a signal too. (for request aborting)

Yeah, we can definitely add that as well.

@Nytelife26
Copy link
Collaborator Author

@wonderlandpark Can you file that as a separate issue please, under a feature request? :)

@wonderlandpark
Copy link

@wonderlandpark Can you file that as a separate issue please, under a feature request? :)

Added at #22

@tbnritzdoge tbnritzdoge self-assigned this Apr 13, 2021
@tbnritzdoge tbnritzdoge mentioned this issue Apr 21, 2021
Closed
@tbnritzdoge tbnritzdoge linked a pull request Jun 21, 2021 that will close this issue
feat: broad improvments #33
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nytelife26 Nytelife26

@tbnritzdoge tbnritzdoge

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: broad improvments helperdiscord/petitio
3 participants
@Nytelife26 @wonderlandpark @tbnritzdoge