updating locust to use Locust v0.9.0

[sekka1]

What this PR does / why we need it:

This updates Locust to the latest v0.9.0. It also uses the Dockerfile in the Locust Github repo as the standard image.

Which issue this PR fixes

none

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sekka1
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mattfarina

If they are not already assigned, you can assign the PR to them by writing /assign @mattfarina in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @sekka1. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sekka1]

@cpanato Here is the new PR with only the Locust v0.9.0 update.

[sekka1]

@cpanato can you approve?

[cpanato]

@sekka1 you need to sign the DCO

What happens with the previous image repo? is this new an official one?

[sekka1]

Signed the DCO.

This is still the image from my repo. Still trying to get them to get their own image: locustio/locust#849

[cpanato]

i would defer to the chart maintainers this PR @unguiculus @davidkarlsen

[sekka1]

@unguiculus @davidkarlsen can you take a look at this for updating locust to the latest release?

[sekka1]

@cpanato dont seem like the maintainers of this chart is responding. What would the next options be?

[so0k]

@sekka1 - what is the github repo for your Dockerfile?

the Honestbee Dockerfile is here - https://github.com/honestbee/distributed-load-testing/blob/master/locust-image/app/entrypoint.sh

the entrypoint for the workers used a loop to wait until the master became available, else you'd have a master that starts without the workers registered.

I don't know if Locust 0.9.0 has added fixes to avoid that scenario as I'm no longer at Honestbee and neither me or Honestbee is currently using Locust anymore.

If nobody of the Locust maintainers or community is willing to step up to manage these charts, we might just need to deprecate it - or add sources / references to the README so people can trust the docker images they run.

[sekka1]

@so0k Here is the Dockerfile: https://github.com/locustio/locust/blob/master/Dockerfile

There dont seem to be any loops on the worker waiting for the master. I didnt seem to run into this issue when i was using this.

Perhaps I should rather post this chart to the locust github repo instead and see if they will take it in?

[sekka1]

@so0k No answer to my question about them creating an offical docker image: locustio/locust#849

Can we move forward to merging this?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[quorak]

can we please support @sekka1 in getting this done. Current chart is very outdated and there seems to be a lot of interest!

[davidkarlsen]

/ok-to-test

[cpanato]

please follow the doc: https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md#deployments-statefulsets-daemonsets-selectors

beside the app please add release

[cpanato]

Suggested change

	app: {{ template "locust.fullname" . }}
	app: {{ template "locust.fullname" . }}
	release: {{ .Release.Name | quote }}

[cpanato]

/assign

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[stale]

This issue is being automatically closed due to inactivity.

[blaketastic2]

Is there any update to getting this merged?