Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Jaeger operator role resources #11596

Merged
merged 3 commits into from
Feb 22, 2019
Merged

Jaeger operator role resources #11596

merged 3 commits into from
Feb 22, 2019

Conversation

ariefrahmansyah
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah commented Feb 21, 2019 •
edited
Loading

What this PR does / why we need it:

Add jobs and cronjobs resources to jaeger operator role

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @ariefrahmansyah. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 21, 2019
@ariefrahmansyah
Add jobs and cronjobs resources to jaeger operator role
3dafe94 
Signed-off-by: Arief Rahmansyah <ariefrahmansyah@hotmail.com>
@ariefrahmansyah
Bump jaeger-operator version
a78d18e 
Signed-off-by: Arief Rahmansyah <ariefrahmansyah@hotmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Feb 21, 2019
@ariefrahmansyah
Add new api groups for jobs and cron jobs role
bd1690f 
Signed-off-by: Arief Rahmansyah <ariefrahmansyah@hotmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2019
@cpanato
Copy link
Member

cpanato commented Feb 21, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2019
@cpanato
Copy link
Member

cpanato commented Feb 21, 2019

/ok-to-test

@cpanato cpanato closed this Feb 22, 2019
@cpanato cpanato reopened this Feb 22, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2019
@cpanato
Copy link
Member

cpanato commented Feb 22, 2019

/ok-to-test

@cpanato
Copy link
Member

cpanato commented Feb 22, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ariefrahmansyah, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 58ec0e8 into helm:master Feb 22, 2019
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
@ariefrahmansyah @devnulled
Jaeger operator role resources (helm#11596)
e1f346a 
* Add jobs and cronjobs resources to jaeger operator role

Signed-off-by: Arief Rahmansyah <ariefrahmansyah@hotmail.com>

* Bump jaeger-operator version

Signed-off-by: Arief Rahmansyah <ariefrahmansyah@hotmail.com>

* Add new api groups for jobs and cron jobs role

Signed-off-by: Arief Rahmansyah <ariefrahmansyah@hotmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpanato cpanato cpanato approved these changes

@scottrigby scottrigby Awaiting requested review from scottrigby

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/jaeger-operator] Missing cronjob privileges
4 participants
@ariefrahmansyah @k8s-ci-robot @cpanato @helm-bot