Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Lookup* methods for name resolution #30

Open
heistp opened this issue Oct 1, 2021 · 0 comments
Open

switch to Lookup* methods for name resolution #30

heistp opened this issue Oct 1, 2021 · 0 comments

Comments

@heistp
Copy link
Owner

heistp commented Oct 1, 2021

We use ResolveUDPAddr to convert host names to IP addresses, for but "historical reasons", this prefers IPv4 over IPv6, despite the ordering that the local resolver uses (sort of related: golang/go#20911). This isn't the correct behavior. If we switch to one of the Lookup* methods (LookupIP?), that should give us addresses in the order returned by the local resolver.

There are multiple places this is called, there's listen addresses to worry about, and whether or not this works with and without cgo, etc, so this may take some care to get right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant