Skip to content
This repository has been archived by the owner on Mar 19, 2020. It is now read-only.

Use electron-store module instead of localStorage #23

Closed
MasterOfTheTiger opened this issue Jul 6, 2018 · 3 comments
Closed

Use electron-store module instead of localStorage #23

MasterOfTheTiger opened this issue Jul 6, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MasterOfTheTiger
Copy link
Collaborator

MasterOfTheTiger commented Jul 6, 2018 •
edited

I would like to switch things over to https://github.com/sindresorhus/electron-store instead of localStorage for reasons mentioned here: sindresorhus/electron-store#17
@MasterOfTheTiger MasterOfTheTiger added enhancement New feature or request good first issue Good for newcomers labels Jul 6, 2018
@AmazingMech2418
Copy link
Collaborator

We shouldn't use it for the online part.

@MasterOfTheTiger
Copy link
Collaborator Author

No we should not. You are right. However, I am planning a completely new online version built with PhP.

@MasterOfTheTiger
Copy link
Collaborator Author

MasterOfTheTiger commented Jul 21, 2018 •
edited

This is done in commit 179bcdf. All data previously used by people will be deleted when they run the new version. This is no big deal for three reasons:

  1. We are in 0.x still
  2. There is no information that is hard to reobtain
  3. We have no users to affect

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MasterOfTheTiger @AmazingMech2418