Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #244

Merged
merged 26 commits into from
Apr 12, 2023
Merged

Enhancements #244

merged 26 commits into from
Apr 12, 2023

Conversation

carlhiggs
Copy link
Collaborator

This is a major update, as per discussion in #235. In particular, it addresses:

Because of the urgency of issue #242, and the extensive discussion and investigations testing the changes reported in #235 and related issues, I will merge this pull request.

carlhiggs and others added 26 commits March 28, 2023 10:50
…n collating urban covariates to simplify write up of data dictionary for grid and city datasets, as per #230 and #231)
…dy region output folder when generating resources, as per #230
…ut directory and list all generate resources including data, data dictionaries, figure and maps, reports generated along with an advisory note to inspect and confirm appropriateness of outputs prior to dissemination); also amended Docker image to add pygeometa to support generation of metadata (not yet implemented) and remove the platform specific Docker build variable (more experimentation required; this may have caused an issue for an ARM64 platform based user)
…verall study region results summary name from 'city' to 'region' (as someone may use it just for a specific area, that could be a sub-part of a city, or not a city at all)
…(the latter has slow read/write with non-concurrent access that can cause problems; also results in redundant read/writes as data is already written to be read from the database. This commit address #216
, updating the generate resources script (data export to geopackage and csv occurs then)
…to graphml; we were already writing unprojected nodes/edges to the geodatabase ---

 by instead writing the projected ones, we could reload these in network analysis step via graph_from_
gdfs using OSMnx and avoid reading/writing graphml as an extra step.  This addresses #216.  There is a
n oddity -- while end results are basically similar (some slight variation in walkability), the number
 of edges (presumably returned from graph_from_gdfs) was approximately halved for Las Palmas, conseque
ntly the sample points are approximately halved too.  More exploration required to understand why this
 is the case, but perhaps its to do with network directionality...  In any case - results are mostly t
he same while things run faster/more efficiently/less storage space.  So retaining code using this com
mit and then will explore.
…bstracting the core functions (configure OSMnx, generate network, clean intersections, create pgrouting topology); this will make it easier to investigate for discussion #235
curs in the generate resources stage
… one sample point is retained at junction of multiple roads, not multiple)
…as some duplicated loading of edges, nodes from gdfs -- so this was consolidated, and some of the variable names simplifed, removing 'gdf' prefix where not really needed)
…dy region urban intersection using custom boundary when the urban query and urban region have been otherwise defined (#239)
… 'weight' (integer; derived from length) as per #243, as the additional lines of code appear redundant (no tangible time benefit at a negligible cost in precision, not justifying the additional complexity)
@carlhiggs carlhiggs merged commit b35c565 into main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should be able to construct pedestrian network from file without using Overpass Multi-platform Docker build
1 participant