Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listener register and deregister methods connection status #868

Open
mehmettokgoz opened this issue Aug 16, 2022 · 0 comments
Open

Listener register and deregister methods connection status #868

mehmettokgoz opened this issue Aug 16, 2022 · 0 comments

Comments

@mehmettokgoz
Copy link
Contributor

In the current implementation of Listener operations, we are not checking the connection subscribe status and directly use ActiveConnections() to register or deregister the listener. However, there might be some edge cases where we don't have a successful connection and still trying to send request messages or vice versa.

See the following code section: ConnectionListenerBinder#L123

Some difference details between Go and Java clients:

  1. Java client removes all the registered entries if there is an error during the invoke call. Go Client does not remove registered entry for ConnectionListenerBinder.regs map. Check if this creates a problem. (See ConnectionListenerBinder#L87)

  2. Java Client keeps the connection objects after registering the listener while Go Client keeps only the ID pairs in map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant