Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canonicalizePath regressed on Windows between directory-1.3.7.1 and directory-1.3.8.0 #170

Closed
Bodigrim opened this issue Jan 22, 2024 · 2 comments
Closed

canonicalizePath regressed on Windows between directory-1.3.7.1 and directory-1.3.8.0 #170

Bodigrim opened this issue Jan 22, 2024 · 2 comments
Labels
type: a-bug The described behavior is not working as intended.

Comments

@Bodigrim
Copy link
Contributor

directory-1.3.7.1 works correctly on Windows:

> System.Directory.canonicalizePath "\\\\localhost"
"\\\\localhost"

But directory-1.3.8.0 does not:

> System.Directory.canonicalizePath "\\\\localhost"
"C:\\localhost"

I have not tracked the regression further. Might it be related to AFPP refactoring?.. CC @hasufell
@Rufflewind Rufflewind added the type: a-bug The described behavior is not working as intended. label Jan 23, 2024
@hasufell
Copy link
Member

Yeah, just found the regression too. It was indeed introduced by my rewrite of fromExtendedLengthPath.

Can we communicate that this fix needs to go into the next GHC release/releases? Possibly backported.

@Rufflewind
Copy link
Member

From #170 (comment):

Can we communicate that this fix needs to go into the next GHC release/releases? Possibly backported.

@bgamari

@wz1000 wz1000 mentioned this issue Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: a-bug The described behavior is not working as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hasufell @Bodigrim @Rufflewind