use a timer instead of 'After' to avoid leaking resources #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @slackpad |
|
What does a |
|
@sean- the |
|
LGTM |
lattwood
added a commit
to lattwood/yamux
that referenced
this pull request
Jun 14, 2024
In hashicorp#31, the Read path was changed to move away from time.After. This change was not reflected in the Write path, and this commit rectifies that.
|
The write side of this functionality has been added to #127, as well as a bug fix around ensuring stopped Timers have their channels drained when appropriate. |
lattwood
added a commit
to lattwood/yamux
that referenced
this pull request
Jun 17, 2024
In hashicorp#31, the Read path was changed to move away from time.After. This change was not reflected in the Write path, and this commit rectifies that.
lattwood
added a commit
to lattwood/yamux
that referenced
this pull request
Aug 21, 2024
In hashicorp#31, the Read path was changed to move away from time.After. This change was not reflected in the Write path, and this commit rectifies that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling time.After creates a runtime timer that gets scheduled into the runtime. Doing this frequently will bog the scheduler down and have weird effects on the program. Using a timer instead will let us stop the timer and free up those resources when we exit the function