Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth plugins don't have the connection set anymore after grpc plugin #3996

Closed
jhorwit2 opened this issue Feb 17, 2018 · 3 comments · Fixed by #3997
Closed

Auth plugins don't have the connection set anymore after grpc plugin #3996

jhorwit2 opened this issue Feb 17, 2018 · 3 comments · Fixed by #3997
Milestone

Comments

@jhorwit2
Copy link

jhorwit2 commented Feb 17, 2018

Environment:

  • Vault Version: 0.9.3
  • Operating System/Architecture: OL7 & Ubuntu 16.04

Expected Behavior:

The Connection should be set on the logical.Request for auth backends which enables the backend to validate the source IP.

Actual Behavior:

The Connection is always nil after upgrading to the grpc based plugins.

Steps to Reproduce:

Using a GRPC based auth plugin try to get the RemoteAddr of the Connection from the request to the plugin.

@briankassouf
Copy link
Contributor

@jhorwit2 Thanks for the report, this should be fixed in 0.9.4.

@jhorwit2
Copy link
Author

Thanks @briankassouf

Any idea when this and the other plugin related fixes are going to go out in 0.9.4? This is causing a lot of problems for us since it broke a lot of functionality.

@jefferai
Copy link
Member

It'll be soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants