Default prometheusRules.rules should be an empty list, not map #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for prometheus-operator was added in hashicorp#772 and a default empty set of rules was defined as an empty map `{}`. However, as evidenced by the commented out rule examples below that very same values.yaml, this is expected to be a list, so `rules:` value should be set to an empty list `[]`. Because of this Helm issues a warning if you actually define rules and pass them with a --values <filename>: ``` coalesce.go:220: warning: cannot overwrite table with non table for vault.serverTelemetry.prometheusRules.rules (map[]) ```
|
|
tvoran
added
bug
|
Hi @vitaliyf, good spot! It looks like you're right, since PrometheusRule.spec.groups.rules is defined as a list in the operator. We should update the tests in |
|
Superseded by #886. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for prometheus-operator was added in #772 and a default empty set of rules was defined as an empty map
{}. However, as evidenced by the commented out rule examples below that very same values.yaml, this is expected to be a list, sorules:value should be set to an empty list[].Because of this Helm issues a warning if you actually define rules and pass them with a --values :