terraform doesn't cleanup resources from state file

[estahn]

Terraform Version

Terraform v0.12.18
+ provider.aws v2.36.0
+ provider.kubernetes v1.10.0
+ provider.mysql v1.9.0
+ provider.random v2.2.1

Expected Behavior

Terraform should clean up removed modules from the state file.

Actual Behavior

After removing the module from the .tf file, terraform is leaving the following entry in the state file:

    {
      "module": "module.app-db-user-notmidship-unified-api",
      "mode": "managed",
      "type": "mysql_grant",
      "name": "default",
      "each": "list",
      "provider": "provider.mysql.notmidship",
      "instances": []
    },

This will cause the following error message on every run:

Error: Missing required argument

The argument "endpoint" is required, but was not set.


Error: Missing required argument

The argument "username" is required, but was not set.

Workaround

• terraform state pull > terraform.tfstate
• jq '.resources[] | select(.instances | length == 0)' terraform.tfstate
• Manually remove resources from terraform.tfstate
• terraform state push -force terraform.tfstate

[hashibot]

Hello! 🤖

This issue seems to be covering the same problem or request as #23821, so we're going to close it just to consolidate the discussion over there. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.