-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_kubernetes_flux_configuration
and azurerm_arc_kubernetes_flux_configuration
#21579
New Resource: azurerm_kubernetes_flux_configuration
and azurerm_arc_kubernetes_flux_configuration
#21579
Conversation
9cea068
to
1c5dff5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @ms-zhenhua.
I made a first pass through and left some comments that need to be addressed. Once those are done and applied to both resources we can take another look through!
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource.go
Show resolved
Hide resolved
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource_test.go
Outdated
Show resolved
Hide resolved
Hi @stephybun, thank you for your review. I have resolved all comments. Kindly help take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ms-zhenhua - would you mind taking a look at the comment I left on the container_id
suggestion?
Hi @stephybun - Thank you for your clarification. I have updated this part. Kindly take another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more comments but other than that this should be good to go!
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource.go
Outdated
Show resolved
Hide resolved
Hi @stephybun, thank you for your review. I have resolved these 2 comments. Kindly take another review. |
c04d201
to
50e17b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ms-zhenhua LGTM 🏖️
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Swagger:
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/stable/2022-11-01/fluxconfiguration.json
Test Result:
--- PASS: TestAccKubernetesFluxConfiguration_requiresImport (1056.82s)
--- PASS: TestAccKubernetesFluxConfiguration_azureBlobWithSasToken (1067.92s)
--- PASS: TestAccKubernetesFluxConfiguration_basic (1145.67s)
--- PASS: TestAccKubernetesFluxConfiguration_azureBlobWithServicePrincipalSecret (1149.14s)
--- PASS: TestAccKubernetesFluxConfiguration_azureBlobWithManagedIdentity (1156.88s)
--- PASS: TestAccKubernetesFluxConfiguration_azureBlobWithServicePrincipalCertificate (1220.02s)
--- PASS: TestAccKubernetesFluxConfiguration_azureBlobWithAccountKey (1223.27s)
--- PASS: TestAccKubernetesFluxConfiguration_update (1234.21s)
--- PASS: TestAccKubernetesFluxConfiguration_privateRepositoryWithSshKey (1263.36s)
--- PASS: TestAccKubernetesFluxConfiguration_complete (1336.38s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/containers 1347.280s
--- PASS: TestAccArcKubernetesFluxConfiguration_azureBlobWithAccountKey (1096.93s)
--- PASS: TestAccArcKubernetesFluxConfiguration_requiresImport (1114.43s)
--- PASS: TestAccArcKubernetesFluxConfiguration_azureBlobWithServicePrincipalSecret (1139.91s)
--- PASS: TestAccArcKubernetesFluxConfiguration_basic (1154.78s)
--- PASS: TestAccArcKubernetesFluxConfiguration_privateRepositoryWithSshKey (1156.55s)
--- PASS: TestAccArcKubernetesFluxConfiguration_azureBlobWithServicePrincipalCertificate (1178.27s)
--- PASS: TestAccArcKubernetesFluxConfiguration_update (1269.06s)
--- PASS: TestAccArcKubernetesFluxConfiguration_azureBlobWithSasToken (1305.40s)
--- PASS: TestAccArcKubernetesFluxConfiguration_complete (1366.15s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/arckubernetes 1409.659s