New Resource : `azurerm_voice_services_communications_gateway` #20607

sinbai · 2023-02-22T07:52:17Z

Test Results:
PASS: TestAccVoiceServicesCommunicationsGateway_basic (281.01s)
PASS: TestAccVoiceServicesCommunicationsGateway_requiresImport (309.40s)
PASS: TestAccVoiceServicesCommunicationsGateway_update (671.47s)
PASS: TestAccVoiceServicesCommunicationsGateway_complete (274.35s)

stephybun

Thanks @sinbai, left some comments in-line but once those are resolved we can take another look and get this merged!

internal/services/voiceservices/voice_services_communications_gateway_resource.go

stephybun · 2023-02-23T10:53:37Z

internal/services/voiceservices/voice_services_communications_gateway_resource.go

+
+		"tags": commonschema.Tags(),
+
+		"teams_voicemail_pilot_number": {


Is this a number or a string?

Suggested change

"teams_voicemail_pilot_number": {

"microsoft_teams_voicemail_pilot_number": {

The microsoft_teams_voicemail_pilot_number is a string since the type of API is string.

internal/services/voiceservices/voice_services_communications_gateway_resource.go

stephybun · 2023-02-23T11:03:03Z

internal/services/voiceservices/voice_services_communications_gateway_resource.go

+				if properties.ApiBridge != nil && *properties.ApiBridge != nil {
+					apiBridgeValue, err := json.Marshal(*properties.ApiBridge)
+					if err != nil {
+						return err


Suggested change

return err

return fmt.Errorf("marshalling value for ApiBridge: %+v", err)

stephybun · 2023-02-23T11:04:37Z

internal/services/voiceservices/voice_services_communications_gateway_resource.go

+	for _, v := range inputList {
+		input := v
+		output := communicationsgateways.ServiceRegionProperties{
+			Name: input.Name,
+		}
+
+		primaryRegionPropertiesValue := expandPrimaryRegionPropertiesModel(input.PrimaryRegionProperties)


Suggested change

for _, v := range inputList {

input := v

output := communicationsgateways.ServiceRegionProperties{

Name: input.Name,

}

primaryRegionPropertiesValue := expandPrimaryRegionPropertiesModel(input.PrimaryRegionProperties)

for _, v := range inputList {

output := communicationsgateways.ServiceRegionProperties{

Name: v.Name,

}

primaryRegionPropertiesValue := expandPrimaryRegionPropertiesModel(v.PrimaryRegionProperties)

stephybun · 2023-02-23T11:07:11Z

internal/services/voiceservices/voice_services_communications_gateway_resource.go

+	var outputList []ServiceRegionPropertiesModel
+	if inputList == nil {
+		return outputList
+	}


Suggested change

var outputList []ServiceRegionPropertiesModel

if inputList == nil {

return outputList

}

outputList := make([]ServiceRegionPropertiesModel, 0)

if inputList == nil {

return outputList

}

stephybun · 2023-02-23T11:08:05Z

internal/services/voiceservices/voice_services_communications_gateway_resource.go

+}
+
+func flattenPrimaryRegionPropertiesModel(input *communicationsgateways.PrimaryRegionProperties) []PrimaryRegionPropertiesModel {
+	var outputList []PrimaryRegionPropertiesModel


Suggested change

var outputList []PrimaryRegionPropertiesModel

outputList := make([]PrimaryRegionPropertiesModel, 0)

stephybun · 2023-02-23T11:08:30Z

internal/services/voiceservices/voice_services_communications_gateway_resource.go

+}
+
+func flattenCommunicationsPlatformModel(input []communicationsgateways.CommunicationsPlatform) []string {
+	var output []string


Suggested change

var output []string

output := make([]string, 0)

sinbai · 2023-02-24T09:44:58Z

Hi @stephybun thanks for your time and feedback. Code has been updated. Could you please take another look?

stephybun

Hi @sinbai, there are still two issues in the schema which have not been resolved from the first review, could you please take a look at them? Thanks!

stephybun · 2023-03-07T12:34:30Z

internal/services/voiceservices/voice_services_communications_gateway_resource.go

+				"name": {
+					Type:         pluginsdk.TypeString,
+					Required:     true,
+					ValidateFunc: validation.StringIsNotEmpty,
+				},


This is still called name this should be called location

Thanks, the code has been updated. Could you please take another look?

stephybun · 2023-03-07T12:35:17Z

internal/services/voiceservices/voice_services_communications_gateway_resource.go

+							"operator_addresses": {
+								Type:     pluginsdk.TypeSet,
+								Required: true,
+								Elem: &pluginsdk.Schema{
+									Type: pluginsdk.TypeString,
+								},
+							},
+							"allowed_media_source_address_prefixes": {
+								Type:     pluginsdk.TypeSet,
+								Optional: true,
+								Elem: &pluginsdk.Schema{
+									Type: pluginsdk.TypeString,
+								},
+							},
+
+							"allowed_signaling_source_address_prefixes": {
+								Type:     pluginsdk.TypeSet,
+								Optional: true,
+								Elem: &pluginsdk.Schema{
+									Type: pluginsdk.TypeString,
+								},
+							},
+
+							"esrp_addresses": {
+								Type:     pluginsdk.TypeSet,
+								Optional: true,
+								Elem: &pluginsdk.Schema{
+									Type: pluginsdk.TypeString,
+								},


These should be flattened and brought a level up, so under service_locations

Thanks, the code has been updated. Could you please take another look?

katbyte

LGTM 🛻

katbyte

sorry noticed something on my last pass.

katbyte · 2023-03-21T02:28:28Z

internal/services/voiceservices/voice_services_communications_gateway_resource_test.go

+  codecs       = "PCMA"
+  platforms    = ["OperatorConnect", "TeamsPhoneMobile"]
+
+  service_locations {


this should be

Suggested change

service_locations {

service_location {

as its a block?

@katbyte thanks for the feedback. The code has been updated. Could you please take another look?

katbyte

Thanks @sinbai - LGTM 🗨️

github-actions · 2023-03-24T05:14:54Z

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-04-24T02:10:31Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added dependencies documentation size/XL labels Feb 22, 2023

sinbai force-pushed the voiceservics/new_resource_communications_gateway branch from 95e2df9 to df4cb60 Compare February 22, 2023 08:43

stephybun requested changes Feb 23, 2023

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Feb 23, 2023

katbyte assigned stephybun Mar 6, 2023

stephybun requested changes Mar 7, 2023

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Mar 7, 2023

sinbai added 2 commits March 8, 2023 14:17

new resource azurerm_voice_services_communications_gateway

0bc555a

update code

341659f

sinbai force-pushed the voiceservics/new_resource_communications_gateway branch from a067553 to ec900b2 Compare March 8, 2023 06:26

update code

c253fb5

sinbai force-pushed the voiceservics/new_resource_communications_gateway branch from ec900b2 to c253fb5 Compare March 8, 2023 06:41

update code

2b29d83

katbyte approved these changes Mar 21, 2023

View reviewed changes

katbyte requested changes Mar 21, 2023

View reviewed changes

github-actions bot added the waiting-response label Mar 21, 2023

update code

69cd76c

github-actions bot removed the waiting-response label Mar 21, 2023

katbyte approved these changes Mar 23, 2023

View reviewed changes

katbyte merged commit b4e3645 into hashicorp:main Mar 23, 2023

github-actions bot added this to the v3.49.0 milestone Mar 23, 2023

katbyte added a commit that referenced this pull request Mar 23, 2023

Update CHANGELOG.md #20607

e41b9cf

sinbai deleted the voiceservics/new_resource_communications_gateway branch March 24, 2023 06:39

github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource : `azurerm_voice_services_communications_gateway` #20607

New Resource : `azurerm_voice_services_communications_gateway` #20607

sinbai commented Feb 22, 2023

stephybun left a comment

stephybun Feb 23, 2023

sinbai Feb 24, 2023

stephybun Feb 23, 2023

sinbai Feb 24, 2023

stephybun Feb 23, 2023

sinbai Feb 24, 2023

stephybun Feb 23, 2023

sinbai Feb 24, 2023

stephybun Feb 23, 2023

sinbai Feb 24, 2023

stephybun Feb 23, 2023

sinbai Feb 24, 2023

sinbai commented Feb 24, 2023

stephybun left a comment

stephybun Mar 7, 2023

sinbai Mar 8, 2023

stephybun Mar 7, 2023

sinbai Mar 8, 2023

katbyte left a comment

katbyte left a comment

katbyte Mar 21, 2023

sinbai Mar 21, 2023

katbyte left a comment

github-actions bot commented Mar 24, 2023

github-actions bot commented Apr 24, 2023


		"tags": commonschema.Tags(),

		"teams_voicemail_pilot_number": {

	"teams_voicemail_pilot_number": {
	"microsoft_teams_voicemail_pilot_number": {

	return err
	return fmt.Errorf("marshalling value for ApiBridge: %+v", err)

	var outputList []PrimaryRegionPropertiesModel
	outputList := make([]PrimaryRegionPropertiesModel, 0)

New Resource : azurerm_voice_services_communications_gateway #20607

New Resource : azurerm_voice_services_communications_gateway #20607

Conversation

sinbai commented Feb 22, 2023

stephybun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sinbai commented Feb 24, 2023

stephybun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 24, 2023

github-actions bot commented Apr 24, 2023

New Resource : `azurerm_voice_services_communications_gateway` #20607

New Resource : `azurerm_voice_services_communications_gateway` #20607