Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example for awscc_accessanalyzer_analyzer #899

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

wellsiau-aws
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Description

First attempt to improve documentation for resource awscc_accessanalyzer_analyzer. I reuse the existing tfplugindocs structure for both templates and examples.

Relates #469

@ewbankkit
Copy link
Contributor

@wellsiau-aws When I run make docs, the changes from your supplied template do not make it into the generated documentation.

@breathingdust breathingdust self-requested a review April 13, 2023 16:26
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@wellsiau-aws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 345f57f into hashicorp:main Apr 13, 2023
@wellsiau-aws wellsiau-aws deleted the d-improve-access-analyzer branch May 12, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants