Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final retry after timeout creating launch config #9781

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_launch_configuration: Final retry after timeout creating launch configuration

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSLaunchConfiguration"            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSLaunchConfiguration -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSLaunchConfigurationDataSource_basic
=== PAUSE TestAccAWSLaunchConfigurationDataSource_basic
=== RUN   TestAccAWSLaunchConfigurationDataSource_securityGroups
=== PAUSE TestAccAWSLaunchConfigurationDataSource_securityGroups
=== RUN   TestAccAWSLaunchConfiguration_importBasic
=== PAUSE TestAccAWSLaunchConfiguration_importBasic
=== RUN   TestAccAWSLaunchConfiguration_basic
=== PAUSE TestAccAWSLaunchConfiguration_basic
=== RUN   TestAccAWSLaunchConfiguration_withBlockDevices
=== PAUSE TestAccAWSLaunchConfiguration_withBlockDevices
=== RUN   TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== PAUSE TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== RUN   TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== PAUSE TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== RUN   TestAccAWSLaunchConfiguration_withSpotPrice
=== PAUSE TestAccAWSLaunchConfiguration_withSpotPrice
=== RUN   TestAccAWSLaunchConfiguration_withVpcClassicLink
=== PAUSE TestAccAWSLaunchConfiguration_withVpcClassicLink
=== RUN   TestAccAWSLaunchConfiguration_withIAMProfile
=== PAUSE TestAccAWSLaunchConfiguration_withIAMProfile
=== RUN   TestAccAWSLaunchConfiguration_withEncryption
=== PAUSE TestAccAWSLaunchConfiguration_withEncryption
=== RUN   TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== PAUSE TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== RUN   TestAccAWSLaunchConfiguration_ebs_noDevice
=== PAUSE TestAccAWSLaunchConfiguration_ebs_noDevice
=== RUN   TestAccAWSLaunchConfiguration_userData
=== PAUSE TestAccAWSLaunchConfiguration_userData
=== CONT  TestAccAWSLaunchConfigurationDataSource_basic
=== CONT  TestAccAWSLaunchConfiguration_withVpcClassicLink
=== CONT  TestAccAWSLaunchConfiguration_withSpotPrice
=== CONT  TestAccAWSLaunchConfiguration_withIAMProfile
=== CONT  TestAccAWSLaunchConfigurationDataSource_securityGroups
=== CONT  TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== CONT  TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== CONT  TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== CONT  TestAccAWSLaunchConfiguration_withBlockDevices
=== CONT  TestAccAWSLaunchConfiguration_basic
=== CONT  TestAccAWSLaunchConfiguration_userData
=== CONT  TestAccAWSLaunchConfiguration_ebs_noDevice
=== CONT  TestAccAWSLaunchConfiguration_importBasic
=== CONT  TestAccAWSLaunchConfiguration_withEncryption
--- PASS: TestAccAWSLaunchConfiguration_importBasic (31.81s)
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (32.83s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (35.38s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (36.39s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (36.39s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (36.65s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (45.36s)
--- PASS: TestAccAWSLaunchConfiguration_basic (54.46s)
--- PASS: TestAccAWSLaunchConfiguration_userData (54.87s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (60.02s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (60.32s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (60.39s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (64.12s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (67.76s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       68.894s

@ryndaniels ryndaniels requested a review from a team August 15, 2019 11:07
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Aug 15, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 15, 2019
@ryndaniels ryndaniels added this to the v2.25.0 milestone Aug 15, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSLaunchConfiguration_importBasic (14.81s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (15.47s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (16.02s)
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (16.14s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (16.05s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (16.45s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (17.32s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (17.49s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (21.34s)
--- PASS: TestAccAWSLaunchConfiguration_userData (21.58s)
--- PASS: TestAccAWSLaunchConfiguration_basic (22.28s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (25.22s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (27.53s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (40.79s)

@ryndaniels ryndaniels merged commit 4cd702a into master Aug 20, 2019
@ryndaniels ryndaniels deleted the rfd-retry-lc branch August 20, 2019 10:00
@ghost
Copy link

ghost commented Aug 23, 2019

This has been released in version 2.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants