Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_ssm_service_setting #13017

Closed
wants to merge 4 commits into from
Closed

New resource: aws_ssm_service_setting #13017

wants to merge 4 commits into from

Conversation

chroju
Copy link
Contributor

@chroju chroju commented Apr 25, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12816

Release note for CHANGELOG:

New Resource: aws_ssm_service_setting

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMServiceSetting_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMServiceSetting_basic -timeout 120m
=== RUN   TestAccAWSSSMServiceSetting_basic
=== PAUSE TestAccAWSSSMServiceSetting_basic
=== CONT  TestAccAWSSSMServiceSetting_basic
--- PASS: TestAccAWSSSMServiceSetting_basic (41.04s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       43.005s

@chroju chroju requested a review from a team April 25, 2020 12:35
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 25, 2020
@chroju chroju closed this Apr 25, 2020
@chroju chroju deleted the add/ssm_service_setting branch April 25, 2020 12:59
@ghost
Copy link

ghost commented May 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 25, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ssm Issues and PRs that pertain to the ssm service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need SSM update-service-setting equivalent
2 participants